New intent module to support network settings. #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s as Abstract class with validate function, make the required changes in template_intent module based on DnacBase class and remove redundant code, with supported states as well
…s, defining docstring etc.
Made changes for PNP with Sanity and unit test
Support validating nested list of dictionary as input, make base clas…
Commit changes from mailine,
rewrite swim module with Base class chnages and add docstring for eac…
Network Settings
Addressed reviewer comments
|
Hello @bvargasre, Can you please review and approve the changes? |
|
Hello @bvargasre and @fmunozmiranda, could you please review and approve the changes? |
fmunozmiranda
merged commit a0efb97
into
cisco-en-programmability:develop
10 checks passed
bvargasre
pushed a commit
that referenced
this pull request
Feb 5, 2024
Adding DNAC log levels for Discovery and PnP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description:
a) A new intent module for network settings to support Global IP Pool, Reserve IP Pool, Global servers, TimeZone, Message of the Day and telemetry servers.
b) By inheriting DNAC base class, changes done to Swim, Template, PnP intent modules.
Testing is done for all the above changes.